fix warnings, add comments for isAuthenticated etc

particle-iot · Apr 7, 2016 · 3401f7d · 3401f7d
1 parent ba767ae
commit 3401f7d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/Example/Spark-SDK.xcodeproj/project.pbxproj b/Example/Spark-SDK.xcodeproj/project.pbxproj
@@ -8,7 +8,6 @@
 
 /* Begin PBXBuildFile section */
 		505D19071B58330F002CF2B7 /* Tests.m in Sources */ = {isa = PBXBuildFile; fileRef = 505D19061B58330F002CF2B7 /* Tests.m */; };
-		5061151C1C20C22E00E468B1 /* CHANGELOG.md in Sources */ = {isa = PBXBuildFile; fileRef = 5061151B1C20C22E00E468B1 /* CHANGELOG.md */; };
 		506976E01B0BF96C0057355B /* Spark-SDK.h in Headers */ = {isa = PBXBuildFile; fileRef = 506976DF1B0BF96C0057355B /* Spark-SDK.h */; };
 		506976E31B0BF97C0057355B /* SparkCloud.h in Headers */ = {isa = PBXBuildFile; fileRef = 506976E11B0BF97C0057355B /* SparkCloud.h */; };
 		506976E41B0BF97C0057355B /* SparkDevice.h in Headers */ = {isa = PBXBuildFile; fileRef = 506976E21B0BF97C0057355B /* SparkDevice.h */; };
@@ -384,7 +383,6 @@
 				6003F59E195388D20070C39A /* SparkAppDelegate.m in Sources */,
 				6003F5A7195388D20070C39A /* SparkViewController.m in Sources */,
 				6003F59A195388D20070C39A /* main.m in Sources */,
-				5061151C1C20C22E00E468B1 /* CHANGELOG.md in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

diff --git a/Pod/Classes/Helpers/KeychainItemWrapper.m b/Pod/Classes/Helpers/KeychainItemWrapper.m
@@ -133,7 +133,7 @@ - (id)initWithIdentifier: (NSString *)identifier accessGroup:(NSString *) access
 
         CFMutableDictionaryRef outDictionary = NULL;
 
-        if (!SecItemCopyMatching((__bridge CFDictionaryRef)tempQuery, (CFTypeRef *)&outDictionary) == noErr)
+        if (!(SecItemCopyMatching((__bridge CFDictionaryRef)tempQuery, (CFTypeRef *)&outDictionary) == noErr))
         {
             // Stick these default values into keychain item if nothing found.
             [self resetKeychainItem];

diff --git a/Pod/Classes/SDK/SparkCloud.h b/Pod/Classes/SDK/SparkCloud.h
@@ -31,15 +31,27 @@ extern NSString *const kSparkAPIBaseURL;
  *  Currently logged in user name, nil if no valid session
  */
 @property (nonatomic, strong, nullable, readonly) NSString* loggedInUsername;
-@property (nonatomic, readonly) BOOL isLoggedIn DEPRECATED_ATTRIBUTE;
+/**
+ *  Currently logged in via app - deprecated
+ */
+@property (nonatomic, readonly) BOOL isLoggedIn __deprecated_msg("Use isAuthenticated instead");
+/**
+ *  Currently authenticated (does a access token exist?)
+ */
 @property (nonatomic, readonly) BOOL isAuthenticated;
 
 /**
  *  Current session access token string, nil if not logged in
  */
 @property (nonatomic, strong, nullable, readonly) NSString *accessToken;
 
+/**
+ *  OAuthClientId unique for your app, use 'particle' for development or generate your OAuth creds for production apps (https://docs.particle.io/reference/api/#create-an-oauth-client)
+ */
 @property (nonatomic, null_resettable, strong) NSString *OAuthClientId;
+/**
+ *  OAuthClientSecret unique for your app, use 'particle' for development or generate your OAuth creds for production apps (https://docs.particle.io/reference/api/#create-an-oauth-client)
+ */
 @property (nonatomic, null_resettable, strong) NSString *OAuthClientSecret;
 
 /**

diff --git a/Pod/Classes/SDK/SparkSession.m b/Pod/Classes/SDK/SparkSession.m
@@ -27,7 +27,7 @@ @interface SparkSession()
 
 @property (nonatomic, strong) NSDate *expiryDate;
 @property (nonatomic, strong) NSTimer *expiryTimer;
-@property (nonatomic, strong, readwrite) NSString *accessToken;
+@property (nonatomic, strong, nullable, readwrite) NSString *accessToken;
 @property (nonatomic, nullable, strong, readwrite) NSString *refreshToken;
 @property (nonatomic, strong, nullable, readwrite) NSString *username;