[TrackerM] Add platform support #2492

keeramis · 2022-07-25T23:59:53Z

Contributors

Description

Adds support for Tracker-M platform

Solution

Add new PLATFORM_ID for trackerm platform, largely based off of P2 module/platform definitions

Steps to Test

Build using new platform and test with trackerm hardware:

make PLATFORM=trackerm APP=tinker clean all

References

SC-105590
SC-107631

Completeness

User is totes amazing for contributing!
Contributor has signed CLA (Info here)
Problem and Solution clearly stated
Run unit/integration/application tests on device
Added documentation
Added to CHANGELOG.md after merging (add links to docs and issues)

keeramis · 2022-07-26T00:02:09Z

hal/src/rtl872x/usart_hal.cpp

+        if (rtsPin_ != PIN_INVALID) {
+            Pinmux_Config(hal_pin_to_rtl_pin(rtsPin_), PINMUX_FUNCTION_UART_RTSCTS);
+            PAD_PullCtrl(hal_pin_to_rtl_pin(rtsPin_), GPIO_PuPd_UP);
+        }


This change was needed for the UART hardware flow control to work as expected.

cc @XuGuohui

hal/src/trackerm/include.mk

avtolstoy

See also CI failures.

Also add to https://github.com/particle-iot/device-os/blob/develop/system/src/system_cloud_internal.cpp#L1113

bootloader/prebootloader/src/tron/part1/sources.mk

bootloader/src/main.c

build/module.mk

dynalib/inc/dynalib.h

dynalib/inc/module_info.inc

user/tests/wiring/sleep20/sleep20.cpp

user/tests/wiring/spi_master_slave/spi_master/spi_master.cpp

user/tests/wiring/spi_master_slave/spi_slave/spi_slave.cpp

wiring_globals/src/spark_wiring_gpio.cpp

bootloader/makefile

bootloader/prebootloader/makefile

hal/src/rtl872x/hal_platform_rtl8721x_config.h

hal/src/rtl872x/pinmap_impl.h

hal/src/trackerm/hal_platform_config.h

hal/src/trackerm/network/network.cpp

system/src/system_sleep.cpp

hal/shared/demux.h

keeramis · 2022-07-27T17:05:22Z

See also CI failures.
Also add to https://github.com/particle-iot/device-os/blob/develop/system/src/system_cloud_internal.cpp#L1113

@avtolstoy Since tracker-m support cellular, it's not needed to mention it in the conditions there, right?

platform/MCU/rtl872x/inc/platform_config.h

dynalib/inc/dynalib.h

XuGuohui

@keeramis There is comments need to be resovled, most of them are related to using HAL_PLATFORM_RTL872X.

hal/src/trackerm/network/network.cpp

hal/src/trackerm/platform_ncp_quectel.cpp

user/inc/Arduino.h

hal/src/rtl872x/hal_platform_rtl8721x_config.h

hal/inc/hal_platform.h

hal/src/rtl872x/gsm0710muxer/platform.h

hal/src/rtl872x/platform_headers.h

avtolstoy · 2022-08-10T18:05:20Z

hal/src/rtl872x/usart_hal.cpp

+        if (rtsPin_ != PIN_INVALID) {
+            Pinmux_Config(hal_pin_to_rtl_pin(rtsPin_), PINMUX_FUNCTION_UART_RTSCTS);
+            PAD_PullCtrl(hal_pin_to_rtl_pin(rtsPin_), GPIO_PuPd_UP);
+        }


cc @XuGuohui

hal/src/trackerm/network/network.cpp

hal/src/trackerm/ota_flash_hal.cpp

hal/src/trackerm/platform_ncp_quectel.cpp

hal/src/tron/network/network.cpp

avtolstoy · 2022-08-12T12:51:27Z

hal/src/tron/network/network.cpp

+    uint8_t deviceId[HAL_DEVICE_ID_SIZE] = {};
+    hal_get_device_id(deviceId, sizeof(deviceId));
+    uint8_t* mac = deviceId + HAL_DEVICE_ID_SIZE - 6;
+    mac[5] += 3;


Nit (can be done in a separate PR): let's add deviceid_hal_impl.h for all platforms (included from deviceid_hal.h, see other _impl.h headers as an example) and for rtl872x add a set of defines for MAC addresses to avoid having to use magic numbers:

HAL_DEVICE_MAC_WIFI_STA = 0 HAL_DEVICE_MAC_WIFI_AP = 1 HAL_DEVICE_MAC_BLE = 2 HAL_DEVICE_MAC_ETHERNET = 3

Let's leave it as-is and I'll get the deviceid hal refactored along with getting the BLE MAC address.

Yup, let's do that 👍

avtolstoy · 2022-08-12T12:55:12Z

@keeramis I've pushed a commit as well to resolve the IRQn issues.

- Rename bootloader/prebootloader/tron -> bootloader/prebootloader/rtl872x - Refactor platform defines - Move HAL_USART_SERIAL2 to respective platform header files - More

keeramis requested review from XuGuohui, avtolstoy and scott-brust July 25, 2022 23:59

keeramis commented Jul 26, 2022

View reviewed changes

hal/src/trackerm/include.mk Outdated Show resolved Hide resolved

avtolstoy requested changes Jul 26, 2022

View reviewed changes

XuGuohui requested changes Jul 26, 2022

View reviewed changes

jmwilson reviewed Jul 26, 2022

View reviewed changes

hal/shared/demux.h Outdated Show resolved Hide resolved

jmwilson reviewed Jul 29, 2022

View reviewed changes

platform/MCU/rtl872x/inc/platform_config.h Outdated Show resolved Hide resolved

jmwilson reviewed Jul 29, 2022

View reviewed changes

dynalib/inc/dynalib.h Outdated Show resolved Hide resolved

keeramis force-pushed the SC105590/tracker-m-platform branch 2 times, most recently from b6f98a2 to cea631c Compare August 4, 2022 05:23

keeramis requested review from avtolstoy, jmwilson and XuGuohui August 4, 2022 13:46

keeramis added feature needs review labels Aug 4, 2022

keeramis added this to the 5.0.0 milestone Aug 4, 2022

XuGuohui requested changes Aug 5, 2022

View reviewed changes

keeramis force-pushed the SC105590/tracker-m-platform branch 3 times, most recently from ac290e9 to bcb67e8 Compare August 10, 2022 06:50

keeramis requested a review from XuGuohui August 10, 2022 14:13

keeramis force-pushed the SC105590/tracker-m-platform branch from 3cd1f95 to b54b421 Compare August 10, 2022 14:44

avtolstoy requested changes Aug 10, 2022

View reviewed changes

keeramis force-pushed the SC105590/tracker-m-platform branch 2 times, most recently from 7240d5f to 9e01d92 Compare August 11, 2022 20:35

avtolstoy approved these changes Aug 12, 2022

View reviewed changes

James Wilson and others added 21 commits August 17, 2022 03:12

Add interrupts for IO expander

75914c9

Add cellular sources to p2 build

a40a13b

Copy quectel stuff from device-os public

1e2c433

Update tron pins for cell modem GPIOs and start cell manager

f8e144c

Comment out WiFi and enable cell NCP

d83377e

Reverse levels and disable flow control

eb4d4ce

Turn off DMA on modem's UART

7da80dc

Don't use hardware UART events to get BG95 mux working

9850d28

Re-enable flow control with Keerthy's change to rtl827x/usart_hal.cpp

56b8b44

Add trackerm platform support

4ad73fa

Refactor and move demux and ioexpander source files to hal/shared

a055368

Clean up

8754af4

minor

35e7faa

Address review comments

071f6c0

- Rename bootloader/prebootloader/tron -> bootloader/prebootloader/rtl872x - Refactor platform defines - Move HAL_USART_SERIAL2 to respective platform header files - More

Address review comments

97b8d18

[rtl872x] fixup sdk headers

4b1bc78

fix wlan interfaces and minor

ce920e8

Enable HAL_PLATFORM_WIFI for trackerm and other minor

13420eb

Fix reading ncp id

0e16984

GuoHui's fix to address multi byte serial stream in hal usart

817aa79

[third_party] ambd_sdk: update submodule reference

bc26a6d

avtolstoy force-pushed the SC105590/tracker-m-platform branch from 382b51c to bc26a6d Compare August 16, 2022 20:17

avtolstoy added 4 commits August 17, 2022 03:20

[rtl872x] fixup irqn defines

7d82ff2

[buildpack] add trackerm

d29e6e7

[build] minor fix in release scripts fro trackerm

ab06eac

[build] enumerate_build_matrix.sh add trackerm

0c977b3

avtolstoy merged commit 7f578c5 into develop Aug 16, 2022

avtolstoy deleted the SC105590/tracker-m-platform branch August 16, 2022 22:00

keeramis removed the DO NOT MERGE label Aug 17, 2022

technobly mentioned this pull request Aug 18, 2022

Device OS v5.0.0 Changes #2517

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TrackerM] Add platform support #2492

[TrackerM] Add platform support #2492

keeramis commented Jul 25, 2022 •

edited by technobly

Loading

keeramis Jul 26, 2022

avtolstoy Aug 10, 2022

avtolstoy left a comment

keeramis commented Jul 27, 2022

XuGuohui left a comment

avtolstoy Aug 10, 2022

avtolstoy Aug 12, 2022

XuGuohui Aug 16, 2022

avtolstoy Aug 16, 2022

avtolstoy commented Aug 12, 2022

[TrackerM] Add platform support #2492

[TrackerM] Add platform support #2492

Conversation

keeramis commented Jul 25, 2022 • edited by technobly Loading

Contributors

Description

Solution

Steps to Test

References

Completeness

keeramis Jul 26, 2022

Choose a reason for hiding this comment

avtolstoy Aug 10, 2022

Choose a reason for hiding this comment

avtolstoy left a comment

Choose a reason for hiding this comment

keeramis commented Jul 27, 2022

XuGuohui left a comment

Choose a reason for hiding this comment

avtolstoy Aug 10, 2022

Choose a reason for hiding this comment

avtolstoy Aug 12, 2022

Choose a reason for hiding this comment

XuGuohui Aug 16, 2022

Choose a reason for hiding this comment

avtolstoy Aug 16, 2022

Choose a reason for hiding this comment

avtolstoy commented Aug 12, 2022

keeramis commented Jul 25, 2022 •

edited by technobly

Loading