[Linux - Fix] Dynamic libraries no longer deadlock when missing, and use the correct headers #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodikuu
added
the
2. Review requested
bmcnett
reviewed
May 21, 2024
| @@ -246,6 +56,12 @@ static bool libjpeg_global_init(void) | |||
| bool r = true; | |||
|
|
|||
| LIBJPEG_SO = MTY_SOLoad("libjpeg.so.8"); | |||
| if (!LIBJPEG_SO) | |||
There was a problem hiding this comment.
i would have probably factored out a function that takes an array of strings, and attempts to MTY_SOLoad each in turn, because we do it for N libraries M times each. and, it would make it easy for us to add logging etc. in a central spot, without having to paste the logging code multiple times.
Namaneo
approved these changes
May 24, 2024
Namaneo
added
3. 2nd review stage
RonaldH-Parsec
approved these changes
Jul 15, 2024
Kodikuu
changed the title
Kodikuu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would've done the same for libcrypto, libcurl, libssl, libudev, and libx11, but those appear more involved, and seem to be more consistent between versions. It would take much more time to extend this work to those.
Install
libasound2-dev,libjpeg-dev, andlibpng-dev, to build MTY on Linux