Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements #67

Merged
merged 5 commits into from
Jan 19, 2024
Merged

More improvements #67

merged 5 commits into from
Jan 19, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 22, 2023

See the commit messages for more information.

`node-executor` is pulling in `kitchensink-runtime` and that is not
really required by `try-runtime-cli`. `node-executor` is also build for
the test `Substrate` node and should not be used outside of the repo.
Otherwise you can pass `--path` and `--snapshot-path` together and get
confused.
cli/main.rs Show resolved Hide resolved
@liamaharon
Copy link
Contributor

Tests seem flakey after this change, taking a look before merging.

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-16 at 18 12 10

There's a missing host function error when running execute-block it seems @bkchr ?

I can take a closer look later this week if you don't have time

@bkchr
Copy link
Member Author

bkchr commented Jan 16, 2024

🙄 I know what this is.

@bkchr bkchr merged commit 4677c9c into main Jan 19, 2024
4 checks passed
@bkchr bkchr deleted the bkchr-improvements branch January 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants