Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to enumerated types #50

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Refactor to enumerated types #50

merged 5 commits into from
Nov 3, 2023

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Nov 1, 2023 •
edited
Loading

Boolean options replaced with an enumerated types
to improve readability of the code.

liamaharon
liamaharon reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just some minor comments.

core/src/state.rs Outdated Show resolved Hide resolved
core/src/state.rs Outdated Show resolved Hide resolved
rustfmt.toml Outdated Show resolved Hide resolved
@simonsso
Stable build and Refactor to enumerated types
9dfd152 
Boolean options replaced with an enumerated types
to improve readability of the code.
@simonsso
Copy link
Contributor Author

simonsso commented Nov 1, 2023

Thanks for this! Just some minor comments.

Thanks for your very useful comments, I have updated PR,
Sorry for the force push but I was not sure if you would merge or squash the commit for a nice history.

liamaharon
liamaharon approved these changes Nov 2, 2023
View reviewed changes
core/src/state.rs Outdated Show resolved Hide resolved
core/src/state.rs Outdated Show resolved Hide resolved
@liamaharon
Copy link
Contributor

Sorry for the force push but I was not sure if you would merge or squash the commit for a nice history.

No worries. I'll squash merge, so feel free to push as many commits as you like here.

@liamaharon liamaharon added the enhancement New feature or request label Nov 2, 2023
@liamaharon
Copy link
Contributor

liamaharon commented Nov 3, 2023 •
edited
Loading

@simonsso could you please merge master into here so we can make sure it passes your tweaked CICD checks?

@simonsso simonsso changed the title Stable build and Refactor to enumerated types Refactor to enumerated types Nov 3, 2023
@liamaharon liamaharon merged commit a72d592 into paritytech:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsso @liamaharon