Use stable toolchain
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file Rather than demand a version, we can allow for the latest stable. Perhaps a bit more prone to breaking on changes but then users are not forced to use this version... I hope we don't _require_ this version 🤞
|
not 100% sure but I think that the workflow doesn't need to demand rustdoc here try-runtime-cli/.github/workflows/rust-docs.yaml Lines 21 to 22 in 5cd3686 as it's in the toolchain 🤔 perhaps helps minimize what that needs too |
liamaharon
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file
Rather than demand a version, we can allow for the latest stable. Perhaps a bit more prone to breaking on changes but then users are not forced to use this version... I hope we don't require this version 🤞
https://rust-lang.github.io/rustup/concepts/profiles.html
we also can be less demanding in what profile we need I think.