Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #24

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Create CONTRIBUTING.md #24

merged 3 commits into from
Sep 22, 2023

Conversation

liamaharon
Copy link
Contributor

Creates a contributing.md based on discussions with @pmikolajczyk41.

@kianenigma we wanted to wait to get your thoughts on this approach before we commit to it.

Copy link
Collaborator

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes:

  1. What do you think will break compatibility, now that this is 100% independent of the runtime? If it is about the inherent providers?
  2. We can also tip contributors here
  3. Some comments seem to pertrain to the pre-mono-repo days, so this needs a broad update, but otherwise seems pretty good

@liamaharon
Copy link
Contributor Author

liamaharon commented Sep 19, 2023

What do you think will break compatibility, now that this is 100% independent of the runtime? If it is about the inherent providers?

Could be anything like runtime apis changes, block format changes, inherent changes, etc. I don't think these will be very frequent.

We can also tip contributors here

That's great given the amount of mentor issues, I was going to ask you about that. Are you thinking we would set up the tip bot here or manually create tips?

@liamaharon liamaharon merged commit 533a122 into main Sep 22, 2023
@liamaharon liamaharon deleted the liamaharon-contributing-md branch September 22, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants