This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bound RewardPoints in pallet-staking
#12125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Aug 27, 2022
bin/node/runtime/src/lib.rs
Outdated
| @@ -569,6 +569,7 @@ impl pallet_staking::Config for Runtime { | |||
| type OnStakerSlash = NominationPools; | |||
| type WeightInfo = pallet_staking::weights::SubstrateWeight<Runtime>; | |||
| type BenchmarkingConfig = StakingBenchmarkingConfig; | |||
| type MaxRewardPoints = ConstU32<300>; | |||
There was a problem hiding this comment.
The number of keys in this map is the number of validators -- staking should have a single MaxValidators, and use that as the bound for this type as well.
There was a problem hiding this comment.
was wondering about that, thanks!
kianenigma
reviewed
Sep 1, 2022
|
|
||
| // Maximum number of validators. | ||
| #[pallet::constant] | ||
| type MaxValidators: Get<u32>; |
There was a problem hiding this comment.
When we set the ValidatorCount, we should make sure we are not above this limit.
kianenigma
reviewed
Sep 1, 2022
|
overlaps with #11967 |
kianenigma
reviewed
Sep 5, 2022
| impl<T: Config> EraRewardPoints<T> { | ||
| fn add_points(&mut self, validator: T::AccountId, reward_points: u32) -> Result<(), Error<T>> { | ||
| let mut points = self.individual.get(&validator).map(|x| *x).unwrap_or_default(); | ||
| points += reward_points; |
There was a problem hiding this comment.
Suggested change
| points += reward_points; | |
| points = points.saturating_add(reward_points); |
|
@kianenigma there is still panicking code in the runtime, I am working on it. |
Doordashcon
changed the title
Doordashcon
changed the title
RewardPoints in pallet-staking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously #12039