deflate: Fix no_context_takeover parameter handling and implement context_takeover. #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issue #49 as well.
Analysis
The existing code did not implement context takeover, so it should always send
client_no_context_takeover
andserver_no_context_takeover
in theSec-WebSocket-Extensions
header, but it didn't.Further investigation showed that my use-case (lots of small messages) would really benefit from context takeover, increasing the compression ratio up to ten fold.
Fix