This repository has been archived by the owner on Sep 19, 2019. It is now read-only.
Move fixed-hash and uint to parity-common; remove tests crate #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure about that. What's wrong in parity-common using this library as a dependency? |
dvdplm
changed the title
|
Ping @tomusdrw @niklasad1 ptal? @debris wrt to your concerns, see discussion in paritytech/parity-common#12 |
debris
approved these changes
Aug 3, 2018
tomusdrw
approved these changes
Aug 4, 2018
| @@ -11,7 +11,8 @@ repository = "https://github.com/paritytech/primitives" | |||
| [dependencies] | |||
| tiny-keccak = "1.4" | |||
| crunchy = { version = "0.1.6", features = ["limit_256"] } | |||
| fixed-hash = { version = "0.2.1", path = "../fixed-hash", default-features = false } | |||
| # TODO: remove `branch` when https://github.com/paritytech/parity-common/pull/12 lands | |||
There was a problem hiding this comment.
I also think it would be best to actually use crates.io version instead of git repo.
There was a problem hiding this comment.
Seems it landed already
Good catch, will fix.
I also think it would be best to actually use crates.io version instead of git repo.
I agree with this (strongly) but I wanted to wait until this stuff lands in polkadot (this poorly named PR) and the dust settles a little bit.
…tives into chore/remove-fixed-hash * 'chore/remove-fixed-hash' of github.com:paritytech/primitives: Add `rust-toolchain` file update dependencies to the `primitives repo` Add a new crate for testing `no-std` Add a new crate for testing `no-std` make it work on no-std by disabling default ft fix error on nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
fixed-hashanduintcrates toparity-common: PR and chops up thetestssubcrate and moving the parts to the relevant crates: optimised multiplication, serialization and conversion tests toethereum-typesand core instantiation and basic arithmetic touint/fixed-hash.NOTE Can be reviewed but need a final tweak after parity-common#12 is merged before this can be merged to fixup the import path in
Cargo.toml.