Migrate pallet-referenda to use umbrella crate #7236
+68
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Jan 28, 2025
substrate/frame/referenda/src/lib.rs
Outdated
| BoundedVec, | ||
| }; | ||
| use frame_system::pallet_prelude::BlockNumberFor; | ||
|
|
| traits::{AtLeast32BitUnsigned, Bounded, Dispatchable, One, Saturating, Zero}, | ||
| DispatchError, Perbill, | ||
| }; | ||
|
|
| @@ -96,9 +94,9 @@ pub mod v1 { | |||
| /// Transforms a submission deposit of ReferendumInfo(Approved|Rejected|Cancelled|TimedOut) to | |||
| /// optional value, making it refundable. | |||
| pub struct MigrateV0ToV1<T, I = ()>(PhantomData<(T, I)>); | |||
| impl<T: Config<I>, I: 'static> OnRuntimeUpgrade for MigrateV0ToV1<T, I> { | |||
| impl<T: Config<I>, I: 'static> frame::traits::OnRuntimeUpgrade for MigrateV0ToV1<T, I> { | |||
| #[cfg(feature = "try-runtime")] | ||
| fn pre_upgrade() -> Result<Vec<u8>, TryRuntimeError> { | ||
| fn pre_upgrade() -> Result<Vec<u8>, frame::try_runtime::TryRuntimeError> { |
| traits::{schedule::v3::Anon, Bounded}, | ||
| Parameter, | ||
| }; | ||
|
|
substrate/frame/src/lib.rs
Outdated
| Dispatchable, One, ReduceBy, ReplaceWithDefault, SaturatedConversion, Saturating, | ||
| StaticLookup, TrailingZeroInput, Zero, | ||
| }, | ||
| BuildStorage, DispatchError, DispatchResult, FixedI64, PerThing, Perbill, |
There was a problem hiding this comment.
DispatchResult is already imported from frame-support and DispatchError is imported below.
Suggested change
| BuildStorage, DispatchError, DispatchResult, FixedI64, PerThing, Perbill, | |
| BuildStorage, FixedI64, PerThing, Perbill, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504
Polkadot Address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1