Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport/stable2412: chainHead: Always report discarded items for storage operations #6842

Merged
merged 1 commit into from
Dec 11, 2024
Merged

backport/stable2412: chainHead: Always report discarded items for storage operations #6842

merged 1 commit into from
Dec 11, 2024
+20 −6

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Dec 11, 2024 •
edited
Loading

@lexnv @actions-user
chainHead: Always report discarded items for storage operations (#6760)
ee9fe2d 
This PR ensures that substrate always reports discarded items as zero.
This is needed to align with the rpc-v2 spec

Closes: #6683


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@lexnv lexnv added the A3-backport Pull request is already reviewed well in another branch. label Dec 11, 2024
@lexnv lexnv self-assigned this Dec 11, 2024
@lexnv lexnv requested a review from EgorPopelyaev December 11, 2024 09:49
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 2223370 into stable2412 Dec 11, 2024
195 of 201 checks passed
@EgorPopelyaev EgorPopelyaev deleted the lexnv/backport-chainhead branch December 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@EgorPopelyaev EgorPopelyaev Awaiting requested review from EgorPopelyaev

Assignees

@lexnv lexnv

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexnv @niklasad1 @EgorPopelyaev