Remove collation-generation subsystem from validator nodes #6832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bastian Köcher <[email protected]>
This reverts commit 73860e6.
…=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_democracy
|
Label needed please 🙏 |
alindima
added
the
T8-polkadot
why did you choose to do this? |
alindima
reviewed
Dec 11, 2024
I am still trying to figure out how to use the |
|
@alindima , thank you for the hint!!! this time all the tests are good. I also did the change for |
alindima
approved these changes
Dec 11, 2024
s0me0ne-unkn0wn
approved these changes
Dec 12, 2024
sandreim
approved these changes
Dec 12, 2024
Merged
via the queue into
paritytech:master
with commit Dec 12, 2024
50e5dd2
201 of 202 checks passed
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
…h#6832) # Description Issue paritytech#6476 Collation-generation is not needed for validators node, and should be removed. ## Implementation Use a `DummySubsystem` for `collation_generation` --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #6476
Collation-generation is not needed for validators node, and should be removed.
Implementation
Use a
DummySubsystemforcollation_generation