Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove collation-generation subsystem from validator nodes #6832

Merged
merged 158 commits into from
Dec 12, 2024
Merged

Remove collation-generation subsystem from validator nodes #6832

merged 158 commits into from
Dec 12, 2024
+18 −4

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Dec 10, 2024 •
edited
Loading

Description

Issue #6476
Collation-generation is not needed for validators node, and should be removed.

Implementation

Use a DummySubsystem for collation_generation

ndkazu and others added 30 commits July 8, 2024 22:26
@ndkazu
Removed libp2p dependancy from sc_network_sync
51f9a34
@ndkazu
Preparing an alternative to libp2p dependant OutBoundFailure
b4e3f5a
@ndkazu
Merge branch 'master' into libp2p
fa242e5
@ndkazu
Agnostic sc-network-sync
6a1fcf1
@ndkazu
Merge branch 'paritytech:master' into libp2p
b20e332
@ndkazu
Merge branch 'master' into libp2p
fdac723
@ndkazu @bkchr
Update substrate/client/network/src/request_responses.rs
b33728b 
Co-authored-by: Bastian Köcher <[email protected]>
@ndkazu
Remove crate libp2p from sc-authority-discovery
d8fbc30
@ndkazu
Merge branch 'libp2p' of github.com:ndkazu/polkadot-sdk into libp2p
86d50af
@ndkazu
Removed event
2f09ebd
@ndkazu
Add a custom InboundFailure
d0e2084
@ndkazu
Removed the variant Network
3f7e5ad
@ndkazu
Changed the type of
6dd1bd3
@ndkazu
Merge branch 'master' into libp2p
97a5453
@ndkazu
Merge branch 'master' into libp2p
12db7fa
@ndkazu
Merge branch 'paritytech:master' into libp2p
02f0085
@ndkazu
Replaced Network2 by Network, and added comments to enums
372f9fc
@ndkazu
Replaced Network2 by Network
28830fe
@ndkazu
Removed Event0, Need to remove ToSwarm dependance to libp2p
f02b17c
@ndkazu
Merge branch 'paritytech:master' into libp2p
ccbc94a
@ndkazu
Merge branch 'master' into libp2p
7229689
@ndkazu
Merge branch 'paritytech:master' into libp2p
8609e59
@ndkazu
Ready for review
54c54c5
@ndkazu
First corrections
ae006e1
@ndkazu
Second round of corrections
a52c9d4
@ndkazu
cargo +nightly fmt
73860e6
@ndkazu
Merge branch 'master' into libp2p
7ed1124
@ndkazu
Revert "cargo +nightly fmt"
db03bc5 
This reverts commit 73860e6.
@ndkazu
Merge branch 'master' into libp2p
3dd3834
".git/.scripts/commands/fmt/fmt.sh"
f194e5f
@ndkazu
Copy link
Contributor Author

ndkazu commented Dec 10, 2024

Label needed please 🙏

@alindima alindima added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Dec 11, 2024
@alindima
Copy link
Contributor

Set the blocking attribute on the collation_generation subsystem

why did you choose to do this?

@ndkazu
Copy link
Contributor Author

ndkazu commented Dec 11, 2024

Set the blocking attribute on the collation_generation subsystem

why did you choose to do this?

I am still trying to figure out how to use the orchestra_proc_macro, crate, and I just realized that I misunderstood the use of the blocking attribute.

@ndkazu
Copy link
Contributor Author

ndkazu commented Dec 11, 2024 •
edited
Loading

@alindima , thank you for the hint!!! this time all the tests are good. I also did the change for validator_with_parallel_overseer_builder.

alindima
alindima approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@alindima alindima added this pull request to the merge queue Dec 12, 2024
@alindima alindima linked an issue Dec 12, 2024 that may be closed by this pull request
Remove collation-generation subsystem from validator nodes #6476
Closed
Merged via the queue into paritytech:master with commit 50e5dd2 Dec 12, 2024
201 of 202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@alindima alindima alindima approved these changes

Assignees
No one assigned
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove collation-generation subsystem from validator nodes
6 participants
@ndkazu @alindima @s0me0ne-unkn0wn @sandreim @dmitry-markin @lexnv