Only one ParaId variable in the Parachain Template #6744
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/command prdoc --audience=runtime dev --bump=minor |
|
/cmd --audience runtime_dev --bump minor |
|
Command "--audience runtime_dev --bump minor" has started 🚀 See logs here |
|
Command "--audience runtime_dev --bump minor" has failed ❌! See logs here |
skunert
approved these changes
Dec 3, 2024
|
/cmd --audience runtime_dev --bump minor |
|
Command "--audience runtime_dev --bump minor" has started 🚀 See logs here |
|
Command "--audience runtime_dev --bump minor" has failed ❌! See logs here |
iulianbarbu
approved these changes
Dec 4, 2024
| // You MUST set this to the correct network! | ||
| para_id: 1000, | ||
| }, | ||
| Extensions { relay_chain: "rococo-local".into(), para_id: runtime::PARACHAIN_ID }, |
There was a problem hiding this comment.
nit: can we do the same thing for rococo-local?
iulianbarbu
added
the
R0-silent
pepoviola
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many problems can occur when building and testing a Parachain caused by misconfiguring the paraid.
This can happen when there are 3 different places you need to update!
This PR makes it so a SINGLE location is the source of truth for the ParaId.