Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6684 #6693

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6684 into stable2409 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6684-to-stable2409
git worktree add --checkout .worktree/backport-6684-to-stable2409 backport-6684-to-stable2409
cd .worktree/backport-6684-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 9ec8009c5a8fdf89499fcd2a40df0292d3950efa
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 28, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7835464

@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label Nov 28, 2024
@bkontur bkontur marked this pull request as ready for review November 28, 2024 15:35
@EgorPopelyaev EgorPopelyaev merged commit 0df1dfb into stable2409 Nov 28, 2024
181 of 271 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6684-to-stable2409 branch November 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants