Update pallet conviction voting to support Block Number Provider #6621
+37
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you help review this too @gui1117 |
gui1117
approved these changes
Dec 2, 2024
| doc: | ||
| - audience: Runtime Dev | ||
| description: | | ||
| This PR makes the conviction voting pallet uses the relay chain as a block provider for a parachain on a regular schedule. |
There was a problem hiding this comment.
It doesn't force the conviction voting pallet to use the relay chain block provider,
Suggested change
| This PR makes the conviction voting pallet uses the relay chain as a block provider for a parachain on a regular schedule. | |
| This PR makes the block number provider used in the conviction voting pallet configurable. Before this PR, conviction voting pallet always used the system block number, with this PR some runtime can opt to use the relay chain block number instead. |
|
|
||
| crates: | ||
| - name: pallet-conviction-voting | ||
| bump: minor |
There was a problem hiding this comment.
let's follow rust semver
Suggested change
| bump: minor | |
| bump: major |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BlockNumberProvider config for the conviction voting pallet.
closes part of #6297