Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statement distribution benchmark #6369

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Nov 5, 2024

I've broken this test with #5883 and this is the fix.

The benchmark is now updated to use proper core index and session index for the generated candidates.

TODO:

  • PRDoc

Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim requested a review from AndreiEres November 5, 2024 12:48
@sandreim sandreim added T8-polkadot This PR/Issue is related to/affects the Polkadot network. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 5, 2024
Signed-off-by: Andrei Sandu <[email protected]>
@AndreiEres
Copy link
Contributor

TODO:

  • PRDoc

I think it can go with the silence tag which doesn't require prdocs.

@sandreim sandreim added the R0-silent Changes should not be mentioned in any release notes label Nov 5, 2024
Signed-off-by: Andrei Sandu <[email protected]>
@paritytech paritytech deleted a comment from sandreim Nov 5, 2024
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim enabled auto-merge November 5, 2024 17:03
@sandreim sandreim added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 52a7325 Nov 5, 2024
169 of 171 checks passed
@sandreim sandreim deleted the sandreim/fix_statement_bench branch November 5, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants