[eth-rpc] Fixes #6317
Merged
[eth-rpc] Fixes #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
approved these changes
Oct 31, 2024
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
R0-silent
pgherveou
commented
Oct 31, 2024
pgherveou
changed the title
|
Re-purposed the PR to include various fixes noticed today during testing |
pgherveou
commented
Nov 2, 2024
| @@ -124,7 +124,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("westmint"), | |||
| impl_name: create_runtime_str!("westmint"), | |||
| authoring_version: 1, | |||
| spec_version: 1_016_002, | |||
| spec_version: 1_016_004, | |||
There was a problem hiding this comment.
note: bumping twice as 003 has been pushed to westend already
pgherveou
changed the title
athei
reviewed
Nov 4, 2024
Comment on lines
+306
to
+309
|
|
||
| /// The ratio between the decimal representation of the native token and the ETH token. | ||
| #[pallet::constant] | ||
| type NativeToEthRatio: Get<u32>; |
There was a problem hiding this comment.
Isn't handled by adding the network with the correct decimals to the wallet?
There was a problem hiding this comment.
in theory yes, but in practice no wallet support anything else than 18 decimals MetaMask/metamask-extension#15168
There was a problem hiding this comment.
xermicus
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for the release of eth-rpc & ah-westend-runtime