Dedup nomination targets #6307
Open
Dedup nomination targets #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ank4n
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Just one comment; otherwise, lgtm!
We don’t need to migrate the single account. When they update their nomination, any duplicates will be removed automatically. (You could add a unit test to demonstrate that updating nominations removes old duplicates as well.)
Thank you for your PR!
Ank4n
approved these changes
Nov 2, 2024
gui1117
reviewed
Nov 5, 2024
| @@ -1291,6 +1291,8 @@ pub mod pallet { | |||
| Error::<T>::TooManyTargets | |||
| ); | |||
|
|
|||
| targets.dedup(); | |||
There was a problem hiding this comment.
This removes only consecutive duplicates, do we enforce it is sorted somewhere?
AurevoirXavier
force-pushed
the
dedup-nominators
branch
from
6131b21
to
134f7f6
Compare
AurevoirXavier
commented
Nov 7, 2024
| @@ -1296,21 +1296,26 @@ pub mod pallet { | |||
| Error::<T>::TooManyTargets | |||
| ); | |||
|
|
|||
| let mut targets = targets | |||
| .into_iter() | |||
| .map(|t| T::Lookup::lookup(t).map_err(DispatchError::from)) | |||
There was a problem hiding this comment.
Could we use AccountId here? I'm not sure why we are using the Lookup type here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate the targets during the nomination process.
And I'm not pretty sure this is designed to be liked this.
This was found by the Subscan team. There is only one such special account in Polkadot(need a migration?). The Polkadot Apps UI will filter the selected targets for the users. I assume this uses a custom client to submit the extrinsic.
Note: the targets length affect the weight.
Or should we just return an error?