Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-im-online benchmark to v2 #6295

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier requested a review from a team as a code owner October 30, 2024 15:20
@ggwpez
Copy link
Member

ggwpez commented Oct 30, 2024

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 30, 2024
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

substrate/frame/im-online/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/im-online/src/benchmarking.rs Outdated Show resolved Hide resolved
@re-gius re-gius added this pull request to the merge queue Nov 5, 2024
Merged via the queue into paritytech:master with commit 8b6c6eb Nov 5, 2024
153 of 159 checks passed
@re-gius
Copy link
Contributor

re-gius commented Nov 15, 2024

/tip small

Copy link

Tip for 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y referendum status is 👎: InvalidTxError: {
"type": "Invalid",
"value": {
"type": "Stale"
}
}

@re-gius
Copy link
Contributor

re-gius commented Nov 15, 2024

/tip small

Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @AurevoirXavier (156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y on polkadot).

Referendum number: 1292.
tip

Copy link

The referendum has appeared on Polkassembly.

@AurevoirXavier AurevoirXavier deleted the benchmarkv2-imonline branch December 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants