Code

Collation fetching fairness#4880

Code

Merged

tdimitrov merged 158 commits intomasterparitytech/polkadot-sdk:masterfrom tsv-collator-proto-fairnessparitytech/polkadot-sdk:tsv-collator-proto-fairnessCopy head branch name to clipboardDec 13, 2024

+3,196-1,015

Commits

Commits on Jun 26, 2024

• Collation fetching fairness

  tdimitrov

  committed
  f4738dc

• Comments

  tdimitrov

  committed
  c7074da

• Fix tests and add some logs

  tdimitrov

  committed
  73eee87

Commits on Jun 27, 2024

• Fix per para limit calculation in is_collations_limit_reached

  tdimitrov

  committed
  fa321ce

• Fix default TestState initialization: claim queue len should be equal to allowed_ancestry_len

  tdimitrov

  committed
  96392a5

• clippy

  tdimitrov

  committed
  0f28aa8

Commits on Jun 28, 2024

• Update is_collations_limit_reached - remove seconded limit

  tdimitrov

  committed
  e5ea548

Commits on Jul 1, 2024

• Fix pending fetches and more tests

  tdimitrov

  committed
  9abc898

• Remove unnecessary clone

  tdimitrov

  committed
  c07890b

• Comments

  tdimitrov

  committed
  e50440e

Commits on Jul 2, 2024

• Better var names

  tdimitrov

  committed
  42b05c7

• Fix pick_a_collation_to_fetch and add more tests

  tdimitrov

  committed
  2f5a466

• Fix test: collation_fetching_respects_claim_queue

  tdimitrov

  committed
  ff96ef9

• Add collation_fetching_fallback_works test + comments

  tdimitrov

  committed
  e837689

Commits on Jul 3, 2024

• More tests

  tdimitrov

  committed
  91cdd13

• Fix collation limit fallback

  tdimitrov

  committed
  9f2d59b

• Separate claim_queue_support from ProspectiveParachainsMode

  tdimitrov

  committed
  a10c86d

• Fix comments and add logs

  tdimitrov

  committed
  b39858a

• Update test: collation_fetching_prefer_entries_earlier_in_claim_queue

  tdimitrov

  committed
  b30f340

• Fix pick_a_collation_to_fetch and more tests

  tdimitrov

  committed
  c0f18b9

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  703ed6d

Commits on Jul 4, 2024

• Fix pick_a_collation_to_fetch - iter 1

  tdimitrov

  committed
  fba7ca6

• Fix pick_a_collation_to_fetch - iter 2

  tdimitrov

  committed
  d4f4ce2

• Remove a redundant runtime version check

  tdimitrov

  committed
  5f52712

• formatting and comments

  tdimitrov

  committed
  6c73e24

• pr doc

  tdimitrov

  committed
  752f3cc

• add license

  tdimitrov

  committed
  f0069f1

• clippy

  tdimitrov

  committed
  6b9f0b3

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  authored
  5f6dcdd

Commits on Jul 5, 2024

• Update prdoc/pr_4880.prdoc

  Show description for b8c1b85
  

  tdimitrov

  and

  Overkillus

  authored
  b8c1b85

Commits on Jul 7, 2024

• Limit collations based on seconded count instead of number of fetches

  tdimitrov

  committed
  f26362f

• Undo rename: is_seconded_limit_reached

  tdimitrov

  committed
  d6857fc

Commits on Jul 8, 2024

• fix collation tests

  tdimitrov

  committed
  cde28cd

• collations_fetching_respects_seconded_limit test

  tdimitrov

  committed
  4c3db2a

• nits

  tdimitrov

  committed
  b2bbdfe

Commits on Aug 26, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  e220cb4

• Remove duplicated dependency after merge

  tdimitrov

  committed
  01d121e

• Remove ProspectiveParachainsMode from collator-protocol, validator-side

  tdimitrov

  committed
  7b3c002

• Fix compilation errors in collation tests

  tdimitrov

  committed
  5dffdde

Commits on Aug 30, 2024

• is_seconded_limit_reached uses the whole view

  tdimitrov

  committed
  1c1744b

Commits on Sep 11, 2024

• Fix is_seconded_limit_reached check

  tdimitrov

  committed
  aaccab1

• Trace logs useful for debugging tests

  tdimitrov

  committed
  b1df2e3

• Handle unconnected candidates

  tdimitrov

  committed
  ce3a95e

Commits on Sep 13, 2024

• Rework pre-prospective parachains tests to work with claim queue

  tdimitrov

  committed
  fe3c09d

• Fix collation_fetches_without_claimqueue

  tdimitrov

  committed
  b9ab579

• Test - collation_fetching_prefer_entries_earlier_in_claim_queue

  tdimitrov

  committed
  fe623bc

• Remove collations test file - all tests are moved in prospective_parachains

  tdimitrov

  committed
  d216689

Commits on Sep 16, 2024

• fixup - collation_fetching_prefer_entries_earlier_in_claim_queue

  tdimitrov

  committed
  ea99c7a

Commits on Sep 17, 2024

• New test - collation_fetching_considers_advertisements_from_the_whole_view

  tdimitrov

  committed
  ee155f5

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  55b7902

• Update PRdoc and comments

  tdimitrov

  committed
  515a784

• Combine seconded_per_para and claims_per_para from collations in a single struct

  tdimitrov

  committed
  4ef6919

• No need to handle missing claim queue anymore

  tdimitrov

  committed
  bd7174f

• Remove dead code and fix some comments

  tdimitrov

  committed
  df6165e

• Remove is_seconded_limit_reached and use the code directly due to the weird function params

  tdimitrov

  committed
  4c5c271

• Fix comments

  tdimitrov

  committed
  b0e4627

• pending_for_para -> is_pending_for_para

  tdimitrov

  committed
  d1cf41d

Commits on Sep 19, 2024

• Fix 0011-async-backing-6-seconds-rate.toml - set lookahead to 3 otherwise the chain can't progress in time

  tdimitrov

  committed
  df3a215

Commits on Sep 20, 2024

• Set lookahead in polkadot/zombienet_tests/elastic_scaling/0002-elastic-scaling-doesnt-break-parachains.toml

  tdimitrov

  committed
  b70807b

Commits on Sep 30, 2024

• paras_now -> assigned_paras

  tdimitrov

  committed
  f047036

• Remove a duplicated parameter in update_view

  tdimitrov

  committed
  94e4fc3

• Remove an outdated comment

  tdimitrov

  committed
  386488b

Commits on Oct 2, 2024

• Fix seconded_and_pending_for_para_in_view

  tdimitrov

  committed
  ff312c9

• claim_queue_state becomes unfulfilled_claim_queue_entries - the bool indicating the claim queue entry fulfillment is no longer needed

  tdimitrov

  committed
  88d0307

• For consistency use chain_ids only from test_state

  tdimitrov

  committed
  af78352

Commits on Oct 3, 2024

• Limit the number of advertisements accepted by each peer for spam protection purposes

  tdimitrov

  committed
  d636091

Commits on Oct 7, 2024

• Zombienet test

  tdimitrov

  committed
  2bb82eb

• Rearrange imports

  tdimitrov

  committed
  c782058

• Newline and outdated comment

  tdimitrov

  committed
  903f7f4

Commits on Oct 14, 2024

• Undo lookahead = 3 in zombienet tests

  tdimitrov

  committed
  cefbce8

• Consider what's scheduled on the core when determining assignments

  tdimitrov

  committed
  cb69361

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  1142a90

• Fix a clippy warning

  tdimitrov

  committed
  4438349

Commits on Oct 15, 2024

• Update PRdoc

  tdimitrov

  committed
  e82c386

• Apply suggestions from code review

  Show description for 4b2d4c5
  

  tdimitrov

  and

  Overkillus

  authored
  4b2d4c5

• ".git/.scripts/commands/fmt/fmt.sh"

  

  command-bot

  committed
  1c91371

• Code review feedback

  tdimitrov

  committed
  be34132

• Fix a typo in prdoc

  tdimitrov

  committed
  5c7b2ac

Commits on Oct 16, 2024

• seconded_and_pending_for_para_in_view looks up to the len of the claim queue

  tdimitrov

  committed
  62c6473

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  authored
  9e3f62d

• rerun CI

  tdimitrov

  committed
  a4bc21f

Commits on Oct 18, 2024

• Fix zombienet test

  tdimitrov

  committed
  6c103df

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  authored
  15e3a74

• Relax expected block counts for each para

  tdimitrov

  committed
  d6b35ca

• Bump lookahead and decrease timeout

  tdimitrov

  committed
  586b56b

• Fix ZN pipeline - try 1

  tdimitrov

  committed
  a04d480

• Fix ZN pipeline - try 2

  tdimitrov

  committed
  13d5d15

• Fix ZN pipeline - try 3

  tdimitrov

  committed
  86870d0

• Fix ZN pipeline - try 4

  tdimitrov

  committed
  7b822af

Commits on Oct 21, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  authored
  558c82e

Commits on Oct 24, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  06c0fd0

• Rename ZN test

  tdimitrov

  committed
  ade7f9b

Commits on Oct 28, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  8ba2a80

• Handle merge conflicts

  tdimitrov

  committed
  ab70567

Commits on Nov 7, 2024

• When counting occupied slots from the claim queue consider relay parents below and above the target relay parent

  tdimitrov

  committed
  d24fdc1

• Add a test

  tdimitrov

  committed
  f55390e

• Small style fixes in tests

  tdimitrov

  committed
  a2093ee

• Fix a todo

  tdimitrov

  committed
  ded6fb5

• Fix paths_to_relay_parent

  tdimitrov

  committed
  cda9330

Commits on Nov 8, 2024

• Additional test for paths_to_relay_parent

  tdimitrov

  committed
  505eb24

• Simplifications

  tdimitrov

  committed
  94f573a

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  fa82404

• Resolve merge conflicts

  tdimitrov

  committed
  55e7fb2

• Fix todos

  tdimitrov

  committed
  e27ddd4

• Comment

  tdimitrov

  committed
  a10c0c1

• Remove unneeded log line

  tdimitrov

  committed
  ee11c6a

Commits on Nov 12, 2024

• Update ZN tests and add some additional logs

  tdimitrov

  committed
  f8e3f52

• Remove CollationStatus::WaitingOnValidation and fix pending collations counting

  tdimitrov

  committed
  1c0f93a

• Use slot based collator for 0018-shared-core-idle-parachain

  tdimitrov

  committed
  67321cb

• Use slot based collator for 0019-coretime-collation-fetching fairness

  tdimitrov

  committed
  40cbf2f

• Remove log line assert from coretime-collation-fetching-fairness test

  tdimitrov

  committed
  b30c037

Commits on Nov 14, 2024

• Update coretime-collation-fetching-fairness ZN test to simulate a collator disrespecting the claim queue limits

  tdimitrov

  committed
  9fbed03

• Remove outer_leaves from backing implicit view

  tdimitrov

  committed
  b032c66

• Restore WaitingOnValidation and back_to_waiting

  tdimitrov

  committed
  eb0ca12

Commits on Nov 15, 2024

• Update polkadot/node/network/collator-protocol/src/validator_side/mod.rs

  Show description for 00fafd4
  

  tdimitrov

  and

  alindima

  authored
  00fafd4

• Don't fetch availability cores

  tdimitrov

  committed
  61e3a80

• Fix a log message and remove 'outer' from comments/variable names.

  tdimitrov

  committed
  5b741d2

• Small refactor in seconded_and_pending_for_para_below and seconded_and_pending_for_para_above + comments

  tdimitrov

  committed
  56eac5d

• Comments + test name

  tdimitrov

  committed
  9607e1c

• Remove activated from update_view in tests

  tdimitrov

  committed
  02ed2ae

• Remove cores from TestState

  tdimitrov

  committed
  fe7f944

Commits on Nov 18, 2024

• Fix ensure_seconding_limit_is_respected

  tdimitrov

  committed
  a31bf6f

• newline

  tdimitrov

  committed
  d251a14

• clippy

  tdimitrov

  committed
  7c39070

• fmt

  tdimitrov

  committed
  5c3e52a

• ".git/.scripts/commands/fmt/fmt.sh"

  

  command-bot

  committed
  2c9721e

Commits on Nov 19, 2024

• Fix PRdoc

  tdimitrov

  committed
  46b4d9f

Commits on Nov 20, 2024

• Remove seconded_and_pending_for_para_below and fix seconded_and_pending_for_para_above

  tdimitrov

  committed
  bf927d2

• Update comment

  tdimitrov

  committed
  d05777b

• new test - claims_above_are_counted_correctly

  tdimitrov

  committed
  f833783

• more tests

  tdimitrov

  committed
  7c807e9

Commits on Nov 21, 2024

• comment

  tdimitrov

  committed
  8f33ba0

Commits on Nov 22, 2024

• Fix path iteration in seconded_and_pending_for_para_above

  tdimitrov

  committed
  1c9db10

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  e6947b9

Commits on Nov 25, 2024

• Remove a debug println

  tdimitrov

  committed
  439291a

Commits on Nov 26, 2024

• Refactor claims counting: project claim queue state on top of relay parents

  tdimitrov

  committed
  3f7691a

• Remove unused code

  tdimitrov

  committed
  b1de6ba

• Trace logs in claim_queue_state

  tdimitrov

  committed
  48d3f5c

• Fix path generation in ensure_seconding_limit_is_respected

  tdimitrov

  committed
  2e0d142

• Rework unfulfilled_claim_queue_entries

  tdimitrov

  committed
  33e5c9f

• paths_from_leaves_via_relay_parent

  tdimitrov

  committed
  5bc63de

• Fix fetch_next_collation_on_invalid_collation

  tdimitrov

  committed
  1a195c1

• paths_via_relay_parent uses block_info

  tdimitrov

  committed
  ac3e1a1

• Fix tests

  tdimitrov

  committed
  31c6cdb

• Comments

  tdimitrov

  committed
  3794e69

• File header and tests for edge cases in claim_queue_state

  tdimitrov

  committed
  3e2acd4

Commits on Nov 27, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  committed
  583f469

• clippy

  tdimitrov

  committed
  eac7a73

• Apply suggestions from code review

  Show description for 3bd85d9
  

  tdimitrov

  and

  alindima

  authored
  3bd85d9

Commits on Nov 28, 2024

• comment

  tdimitrov

  committed
  4b2a67d

• Small refactoring at claim_queue_state

  tdimitrov

  committed
  f3634e1

Commits on Dec 2, 2024

• Apply suggestions from code review

  Show description for 6dd55bf
  

  tdimitrov

  and

  Overkillus

  authored
  6dd55bf

• Fix comments and remove an unneeded error type

  tdimitrov

  committed
  14177ad

• More tests + a small bug fix

  tdimitrov

  committed
  6d9d8b8

• Update PRdoc

  tdimitrov

  committed
  0133a2f

Commits on Dec 11, 2024

• Comments

  tdimitrov

  committed
  33eeb6d

• Accept an advertisement if there is a free spot for it at at least one fork

  tdimitrov

  committed
  8014eba

Commits on Dec 13, 2024

• Merge branch 'master' into tsv-collator-proto-fairness

  tdimitrov

  authored
  2e176b9