Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BEEFY client keystore generic over BEEFY AuthorityId type #2258

Merged
merged 52 commits into from
Feb 8, 2024
Merged

Make BEEFY client keystore generic over BEEFY AuthorityId type #2258

merged 52 commits into from
Feb 8, 2024

Commits on Oct 27, 2023

  1. Fix BeefyAuthorityId::verify for ecdsa_bls_crypto not to use `ecd… 

    …sa_bls::verify`
    @drskalman
    drskalman committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0541cb0 View commit details
    Browse the repository at this point in the history

  2. Fix comment in primitives/consensus/beefy/src/lib.rs

    @drskalman
    drskalman committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    099b86d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. - implement sign/verify_with_hasher for ecdsa_bls377 Pair with … 

    …test

- update `substrate/primitives/consensus/beefy/src/lib.rs` accordingly
    @drskalman
    drskalman committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    033ff57 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Fix typos and improve comment quality 

    Co-authored-by: Davide Galassi <[email protected]>
    @drskalman @davxy
    drskalman and davxy authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    76831b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Add ecdsa_bls377_sign_with_keccak256 to the keystore

    @drskalman
    drskalman committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a0c6d83 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. add and implement ecdsa_bls377_sign_with_keccak256 

    make BEEFY keystore generic over `AuthorityId` and works with both (ECDSA) and (ECDSA, BLS377) key types.
pass all the BEEFY tests for ECDSA
    @drskalman
    drskalman committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    102ad62 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. - Make BEEFY Keyring to be generic over AuthorityId. 

    - Make BEEFY Keystore test generic over `AuthorityId`.
- Implement keystore tests for `ecdsa_bls` crypto.
- Fix `bls::Pair::derive` and write test for it.
    @drskalman
    drskalman committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    25d1afc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into skalman--beefy-clie… 

    …nt-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    05a3ebd View commit details
    Browse the repository at this point in the history

  3. Improve documention and comments 

    Co-authored-by: Robert Hambrock <[email protected]>
    @drskalman @Lederstrumpf
    drskalman and Lederstrumpf authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c860dd0 View commit details
    Browse the repository at this point in the history

  4. Remove unused SimpleKeyPair Trait

    @drskalman
    drskalman committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8958fde View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'skalman--fix-ecdsa-bls-verify-in-beefy-primitives' of h… 

    …ttps://github.com/w3f/polkadot-sdk into skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5ef71c8 View commit details
    Browse the repository at this point in the history

  2. add reasoning on why in BEEFY we want the ECDSA signature on Keccak h… 

    …ash of the message instead of Blake2
    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    3b8eded View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into skalman--fix-ecdsa-bls-verify-in-beefy-pri… 

    …mitives
    @drskalman
    drskalman authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    efb350d View commit details
    Browse the repository at this point in the history

  4. fmt

    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8cfccd8 View commit details
    Browse the repository at this point in the history

  5. Improve documentation 

    Co-authored-by: Davide Galassi <[email protected]>
    @drskalman @davxy
    drskalman and davxy authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a15a60d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into skalman--beefy-client-keystore-supporting-… 

    …both-ecdsa-and-bls
    @drskalman
    drskalman authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    85f8999 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an… 

    …d-bls' of https://github.com/w3f/polkadot-sdk into skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9667c1b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'skalman--fix-ecdsa-bls-verify-in-beefy-primitives' into… 

    … skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b18e2f4 View commit details
    Browse the repository at this point in the history

  9. fmt

    @drskalman
    drskalman committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    00b62ef View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Improve comment quality 

    Co-authored-by: Robert Hambrock <[email protected]>
    @drskalman @Lederstrumpf
    drskalman and Lederstrumpf authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3ef0f65 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'master' into skalman--beefy-client-keystore-supporting-… 

    …both-ecdsa-and-bls
    @drskalman
    drskalman committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a80264c View commit details
    Browse the repository at this point in the history

  2. drop 'perhaps' from generate_with_phrase_should_be_recoverable_with_f… 

    …rom_string_perhaps test and add it to bandersnatch and ed25519
    @drskalman
    drskalman committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3f8d533 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into skalman--beefy-clie… 

    …nt-keystore-supporting-both-ecdsa-and-bls
    @Lederstrumpf
    Lederstrumpf committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1b48d48 View commit details
    Browse the repository at this point in the history

  4. fmt

    @Lederstrumpf
    Lederstrumpf committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5f09d22 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an… 

    …d-bls' of https://github.com/w3f/polkadot-sdk into skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b04880d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Apply suggestions from code review 

    Code and dependency clean-up

Co-authored-by: Davide Galassi <[email protected]>
    @drskalman @davxy
    drskalman and davxy authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6304d1e View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Davide Galassi <[email protected]>
    @drskalman @davxy
    drskalman and davxy authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    7fc1326 View commit details
    Browse the repository at this point in the history

  3. use std instead of sp_std as we are not in the Runtime

    @drskalman
    drskalman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6401a97 View commit details
    Browse the repository at this point in the history

  4. remove sp-std fro Cargo.lock

    @drskalman
    drskalman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    425c3d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an… 

    …d-bls' of https://github.com/w3f/polkadot-sdk into skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    e98945f View commit details
    Browse the repository at this point in the history

  2. Do not re-export internal of primitives/consensus/beefy/src/test_utils

    @drskalman
    drskalman committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    59a4b5f View commit details
    Browse the repository at this point in the history

  3. fix wrong doc for BeefySignerAuthority::sign_with_hasher

    @drskalman
    drskalman committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f2956c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Make BEEFY Keyring itself generic over AuthId using PhantomData.

    @drskalman
    drskalman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3422057 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Compatiblize all client/beefy tests to Keyring<AuthorityId> enum model

    @drskalman
    drskalman committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7454b6d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Remove Sync + Send Bound from <AuthorityIdBound as RuntimeAppPublic>:… 

    …:Signature


Because you have to specify it later explicitly anyway.

Co-authored-by: Davide Galassi <[email protected]>
    @drskalman @davxy
    drskalman and davxy authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    dd686dc View commit details
    Browse the repository at this point in the history

  2. do cargo fmt

    @drskalman
    drskalman committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    34d80cf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an… 

    …d-bls' of github.com:/w3f/polkadot-sdk into skalman--beefy-client-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    10089f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Move function closer to the test

    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0885c2a View commit details
    Browse the repository at this point in the history

  2. Fix some warnings

    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    edc6a9c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into skalman--beefy-client-keystore-supporting-… 

    …both-ecdsa-and-bls
    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9ec36d7 View commit details
    Browse the repository at this point in the history

  4. Fix std feat propagation

    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    cd35b5d View commit details
    Browse the repository at this point in the history

  5. Fix beefy pallet

    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3d5cc36 View commit details
    Browse the repository at this point in the history

  6. Make taplo happy

    @davxy
    davxy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    77bdcfa View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Add reference for the BLS implementation used in substrate

    @drskalman
    drskalman committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ec1ef13 View commit details
    Browse the repository at this point in the history

  2. BEEFY keystore should error if asked to sign with any key beside ECDS… 

    …A or BLS377
    @drskalman
    drskalman committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e4ad716 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Improve bls.rs docs 

    Co-authored-by: Robert Hambrock <[email protected]>
    @drskalman @Lederstrumpf
    drskalman and Lederstrumpf authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    018f13a View commit details
    Browse the repository at this point in the history

  2. Test the private key constructed from phrase is the same as construct… 

    …ed initially.

Co-authored-by: Robert Hambrock <[email protected]>
    @drskalman @Lederstrumpf
    drskalman and Lederstrumpf authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    98a8721 View commit details
    Browse the repository at this point in the history

  3. Verify secret (in)equality in key recovery tests.

    @drskalman
    drskalman committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    2271268 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into skalman--beefy-clie… 

    …nt-keystore-supporting-both-ecdsa-and-bls
    @drskalman
    drskalman committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d0dc187 View commit details
    Browse the repository at this point in the history

  5. discipline rogue "hash to field"s

    @Lederstrumpf
    Lederstrumpf committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3cf2c72 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'master' into skalman--beefy-client-keystore-supporting-… 

    …both-ecdsa-and-bls
    @drskalman
    drskalman authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0bca732 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'master' into skalman--beefy-client-keystore-supporting-… 

    …both-ecdsa-and-bls
    @drskalman
    drskalman authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    10f2f99 View commit details
    Browse the repository at this point in the history