review

substrate/frame/support/procedural/src/construct_runtime/mod.rs

@@ -777,7 +777,6 @@ pub(crate) fn decl_static_assertions(
 	});
 
 	quote! {
-		#[allow(deprecated)]
 		#(#error_encoded_size_check)*
 	}
 }

substrate/frame/support/procedural/src/lib.rs

@@ -376,6 +376,7 @@ pub fn derive_eq_no_bound(input: TokenStream) -> TokenStream {
 	let (impl_generics, ty_generics, where_clause) = input.generics.split_for_impl();
 
 	quote::quote_spanned!(name.span() =>
+		#[allow(deprecated)]
 		const _: () = {
 			impl #impl_generics ::core::cmp::Eq for #name #ty_generics #where_clause {}
 		};

substrate/frame/support/procedural/src/pallet/expand/constants.rs

@@ -45,7 +45,7 @@ pub fn expand_constants(def: &mut Def) -> proc_macro2::TokenStream {
 	let completed_where_clause = super::merge_where_clauses(&where_clauses);
 
 	let mut config_consts = vec![];
-	for const_ in def.config.consts_metadata.iter_mut() {
+	for const_ in def.config.consts_metadata.iter() {
 		let ident = &const_.ident;
 		let const_type = &const_.type_;
 		let deprecation_info = match crate::deprecation::get_deprecation(
@@ -79,7 +79,7 @@ pub fn expand_constants(def: &mut Def) -> proc_macro2::TokenStream {
 	}
 
 	let mut extra_consts = vec![];
-	for const_ in def.extra_constants.iter_mut().flat_map(|d| &mut d.extra_constants) {
+	for const_ in def.extra_constants.iter().flat_map(|d| &d.extra_constants) {
 		let ident = &const_.ident;
 		let deprecation_info = match crate::deprecation::get_deprecation(
 			&quote::quote! { #frame_support },