Skip to content

Commit

Permalink
some review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alindima committed Nov 1, 2024
1 parent 8a4a8e1 commit 65b44eb
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion polkadot/node/collation-generation/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ impl CollationGenerationSubsystem {
core_index,
} = params;

// We need to swap the parent-head data, but all other fields here will be correct.
let mut validation_data = match request_persisted_validation_data(
relay_parent,
config.para_id,
Expand All @@ -211,6 +210,7 @@ impl CollationGenerationSubsystem {
},
};

// We need to swap the parent-head data, but all other fields here will be correct.
validation_data.parent_head = parent_head;

let claim_queue = request_claim_queue(relay_parent, ctx.sender()).await.await??;
Expand Down Expand Up @@ -553,6 +553,15 @@ async fn construct_and_distribute_receipt(

ccr.to_plain()
} else {
if commitments.selected_core().is_some() {
gum::warn!(
target: LOG_TARGET,
?pov_hash,
?relay_parent,
para_id = %para_id,
"Candidate commitments contain UMP signal without v2 receipts being enabled.",
);
}
CandidateReceipt {
commitments_hash: commitments.hash(),
descriptor: CandidateDescriptor {
Expand All @@ -576,6 +585,7 @@ async fn construct_and_distribute_receipt(
?pov_hash,
?relay_parent,
para_id = %para_id,
?core_index,
"candidate is generated",
);
metrics.on_collation_generated();
Expand Down

0 comments on commit 65b44eb

Please sign in to comment.