Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tune the Ordering for the atomic usages #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wang384670111
Copy link

SeqCst is overly restrictive. I believe that the ordering can be appropriately modified.
I think that active is merely signal for multithreading purposes and do not synchronize with other locals. Therefore, using Relaxed ordering should suffice.

if self.active.load(atomic::Ordering::SeqCst) {

self.active.store(false, atomic::Ordering::SeqCst);

jsonrpc/ws/src/session.rs

Lines 277 to 291 in dc9550b

if !active_lock.load(atomic::Ordering::SeqCst) {
return;
}
if let Some(result) = response {
let res = out.send(result);
match res {
Err(error::Error::ConnectionClosed) => {
active_lock.store(false, atomic::Ordering::SeqCst);
}
Err(e) => {
warn!("Error while sending response: {:?}", e);
}
_ => {}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant