Fine-tune the Ordering for the atomic usages #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeqCst
is overly restrictive. I believe that the ordering can be appropriately modified.I think that
active
is merely signal for multithreading purposes and do not synchronize with other locals. Therefore, usingRelaxed
ordering should suffice.jsonrpc/ws/src/metadata.rs
Line 29 in dc9550b
jsonrpc/ws/src/session.rs
Line 166 in dc9550b
jsonrpc/ws/src/session.rs
Lines 277 to 291 in dc9550b