Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes parameters that are not necessary.
Disadvantages:
type_name
method does not currently have stableconst
.type_name
is not necessarily the shortest string, for exampletype_name::<Option<String>>()
may returnOption<String>
orstd::option::Option<std::string::String>
.Advantages:
return
value specified within the parameter has some relationship to the outputreturn
value, when in fact thereturn
value entered within the parameter is only useful as a diagnostic for error output. The documentation oftype_name
within std, on the other hand, is meant to be used for code diagnostic purposes.