This repository has been archived by the owner on May 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised in #52 by implementing the change proposed by @achimcc.
Implementing this fix revealed the additional incorrect behaviour in handling
Option
types mentioned in #52.The three major changes in this PR are
type.type
overtype.displayName
informatData
codec
instead ofvalue
when checking for anOption
type. Usecodec.isSome
andcodec.unwrap
.null
and and empty array at the start ofData
and instead letcreateTypeUnsafe
handle any issues and throw an exception. Catch and return()
in case of any exception.Apologies in advance for the large number of lines changed. The bulk of these changes are due to an extra level of indentation as a result of the try-catch. Any feedback on how to do this more cleanly would be greatly appreciated.