Fix 31.12. bug on DayOfYear

paranoiq · Dec 3, 2019 · aabb0b7 · aabb0b7
1 parent fa49510
commit aabb0b7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Time/Interval/DayOfYearInterval.php b/src/Time/Interval/DayOfYearInterval.php
@@ -51,7 +51,7 @@ public function __construct(DayOfYear $start, DayOfYear $end)
         $startNumber = $start->getNumber();
         $endNumber = $end->getNumber();
 
-        if ($startNumber >= DayOfYear::MAX_NUMBER) {
+        if ($startNumber > DayOfYear::MAX_NUMBER) {
             $startNumber %= DayOfYear::MAX_NUMBER;
             $start = $start->normalize();
         }

diff --git a/tests/src/Time/Interval/DayOfYearInterval.phpt b/tests/src/Time/Interval/DayOfYearInterval.phpt
@@ -111,6 +111,17 @@ Assert::true($interval->intersects($i(15, 23)));
 Assert::false($interval->intersects($i(1, 5)));
 Assert::false($interval->intersects($empty));
 
+
+$i1 = new DayOfYearInterval(
+    DayOfYear::createFromMonthAndDay(12, 31),
+    DayOfYear::createFromMonthAndDay(1, 1),
+);
+$i2 = new DayOfYearInterval(
+    DayOfYear::createFromMonthAndDay(12, 31),
+    DayOfYear::createFromMonthAndDay(1, 3),
+);
+Assert::true($i1->intersects($i2));
+
 // touches()
 Assert::true($interval->touches($i(1, 9)));
 Assert::true($interval->touches($i(21, 23)));