IntervalDataSets do not call equals on incompatible types

paranoiq · Dec 3, 2020 · 613a793 · 613a793
1 parent 5231003
commit 613a793
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Time/IntervalData/DateIntervalData.php b/src/Time/IntervalData/DateIntervalData.php
@@ -29,6 +29,7 @@
 use Tracy\Debugger;
 use function array_shift;
 use function array_values;
+use function get_class;
 use function sprintf;
 use function trim;
 
@@ -228,7 +229,7 @@ public function equals(Equalable $other): bool
      */
     public function dataEquals($otherData): bool
     {
-        if ($this->data instanceof Equalable && $otherData instanceof Equalable) {
+        if ($this->data instanceof Equalable && $otherData instanceof Equalable && get_class($this->data) === get_class($otherData)) {
             return $this->data->equals($otherData);
         }
 

diff --git a/src/Time/IntervalData/NightIntervalData.php b/src/Time/IntervalData/NightIntervalData.php
@@ -29,6 +29,7 @@
 use Tracy\Debugger;
 use function array_shift;
 use function array_values;
+use function get_class;
 use function sprintf;
 use function trim;
 
@@ -228,7 +229,7 @@ public function equals(Equalable $other): bool
      */
     public function dataEquals($otherData): bool
     {
-        if ($this->data instanceof Equalable && $otherData instanceof Equalable) {
+        if ($this->data instanceof Equalable && $otherData instanceof Equalable && get_class($this->data) === get_class($otherData)) {
             return $this->data->equals($otherData);
         }