Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActivateCredential support for TKC #284

Merged
merged 9 commits into from
Nov 18, 2021

Commits on Nov 10, 2021

  1. Add ActivateCredential support for TKC

    This commit adds support for two operations, enabling key attestation
    via the ActivateCredential call. A test has also been added to verify
    attestation using the Endorsement Key.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d57afb1 View commit details
    Browse the repository at this point in the history
  2. Refactor attesting key setup

    Split up the setup for the attesting key into different methods so it's
    clearer what is being done.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    84a79ae View commit details
    Browse the repository at this point in the history
  3. Allow the setting more hierarchy auths in TKC

    This commit expands the scope of the TransientKeyContextBuilder to
    adding more than one hierarchy auth value. This is needed for attesting
    keys with the default Endorsement Key which uses the Endorsement
    Hierarchy for authorization by default.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    9d11249 View commit details
    Browse the repository at this point in the history
  4. A few fixes

    * Changed the serialisation of the TPM2B_Public to use the marshaling
    command
    * Changed the MakeCredParams struct to be fully public to avoid needless
    clones
    * Factored out the code for obtaining the EK public key
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    1f170fc View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Return marshaled TPMT_PUBLIC instead

    Instead of serializing TPM2B_PUBLIC, use the embedded TPMT_PUBLIC
    instead, as this is what the key name is computed over.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    41a3f9d View commit details
    Browse the repository at this point in the history
  2. Add more tests

    Adding more tests for the key attestation operations.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    ec43a0e View commit details
    Browse the repository at this point in the history
  3. Fix usize conversion

    This commit fixes the conversion from `TPMT_PUBLIC` size to the input of
    Tss2_MU_TPMT_PUBLIC_Marshal. A new WrapperErrorKind variant is added for
    internal errors which were not expected (essentially as a replacement
    for `unwrap`).
    
    The cross-compilation script was also moved to run per-commit in the CI
    instead of nightly - the fix above would've been obvious if we tried
    cross-compilation.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    d574d3c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. PR feedback

    Improved the tests to check for the exact response code expected.
    Improved the documentation on `MakeCredentialParams` to detail what the
    contents are meant for.
    
    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    c01cf01 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Adapt test case for swtpm

    Signed-off-by: Ionut Mihalcea <[email protected]>
    ionut-arm committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d523ce2 View commit details
    Browse the repository at this point in the history