Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: Update rustix and bitflags dependencies to latest version #741

Merged

Conversation

tgonzalezorlandoarm
Copy link
Member

Update rustix dependency to its latest version and fix it on:

  • Cargo.lock
  • e2e_tests/Cargo.lock
  • fuzz/Cargo.lock

This has been marked by dependabot in different PRs:

Update rustix dependency to its latest version and fix it on:

 * Cargo.lock
 * e2e_tests/Cargo.lock
 * fuzz/Cargo.lock

Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm added the dependencies Pull requests that update a dependency file label Nov 23, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Nov 23, 2023
 * Keep rustix updated and avoid a dependency mismatch with
   parsec-tool.
 * Update Cargo.lock, e2e_tests/Cargo.lock, fuzz/Cargo.lock

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 23, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
@@ -156,9 +156,9 @@ checksum = "bef38d45163c2f1dde094a7dfd33ccf595c92905c8f8f4fdc18d06fb1037718a"

[[package]]
name = "bitflags"
version = "2.4.0"
Copy link
Contributor

@gowthamsk-arm gowthamsk-arm Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't understand the commit description

* Keep rustix updated and avoid a dependency mismatch with
   parsec-tool.

Will the bitflags crate have different versions in parsec and parsec-tool if we update rustix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tgonzalezorlandoarm/parsec-tool/actions/runs/6972139517/job/18973702435

When checking the current mismatches between parsec and parsec-tool:

---------------------mistmatches----------------------


bitflags                  ['v2.4.1', 'v2.4.0']
rustix                    ['v0.38.18', 'v0.38.21']

As dependabot pointed out, rustix can be updated to its latest. So can bitflags. This PR is doing that.
This is done in parsec-tool as well as part of this parallaxsecond/parsec-tool#116

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will avoid a dependency mismatch between parsec and parsec-tool

@tgonzalezorlandoarm tgonzalezorlandoarm changed the title Cargo.lock: Update rustix to latest version Cargo.lock: Update rustix and bitflags dependencies to latest version Nov 23, 2023
Copy link
Collaborator

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 6fb38a9 into parallaxsecond:main Nov 24, 2023
15 checks passed
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 24, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 24, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 24, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 27, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 27, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this pull request Nov 27, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm added a commit to parallaxsecond/parsec-tool that referenced this pull request Nov 28, 2023
Keep rustix updated and avoid a dependency mismatch with parsec.
Please check:
parallaxsecond/parsec#741

Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/rustix-update branch March 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants