Use Rust 1.78 #151
Open
Use Rust 1.78 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow suggestsions from the compiler. Disable clippy::all lints for now Signed-off-by: Reinhard Tartler <[email protected]>
gowthamsk-arm
requested review from
gowthamsk-arm,
ionut-arm and
tgonzalezorlandoarm
| @@ -9,7 +9,7 @@ readme = "README.md" | |||
| keywords = ["parsec", "interface", "serialization"] | |||
| categories = ["encoding"] | |||
| edition = "2018" | |||
| rust-version = "1.66.0" | |||
| rust-version = "1.78.0" | |||
There was a problem hiding this comment.
We maintain this MSRV for all parsec projects, so we need to keep it at 1.66. Can you please revert this?
| @@ -31,7 +31,7 @@ then | |||
| fi | |||
| if cargo clippy -h | |||
| then | |||
| cargo clippy --all-targets -- -D clippy::all -D clippy::cargo | |||
There was a problem hiding this comment.
Tried it locally and I see new failures with clippy::all.
The errors are particularly of 2 types occurring at multiple places. It would be better to get rid of them instead of dropping this check here.
There was a problem hiding this comment.
Would you be able to fix them in this PR please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow suggestsions from the compiler.
Disable clippy::all lints for now
Fixes: #152
Signed-off-by: Reinhard Tartler [email protected]