Fix ci errors/warnings #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On builds we get the following warning, "warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC <https://rust-lang.github.io/rfcs/2145-type-privacy.html> for more information" Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
fix_ci
branch
2 times, most recently
from
c81a350
to
11378a8
Compare
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
This is a new lint added in 1.75.0 https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions Signed-off-by: Gowtham Suresh Kumar <[email protected]>
|
Is it possible to have a CI Nightly check triggered on this PR so that we can check it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following trivial CI warnings and errors:
frominstead oftry_fromprivate_in_publiclint as it has been removedSigned-off-by: Gowtham Suresh Kumar [email protected]