Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cleanup 01 #645

Merged
merged 27 commits into from
Jul 16, 2021
Merged

Project cleanup 01 #645

merged 27 commits into from
Jul 16, 2021

Conversation

zfi
Copy link
Contributor

@zfi zfi commented Jul 16, 2021

This update is a maintenance patch to correct an number of issues that were identified while investigating an issue where project timestamps were either invalid when displayed in the Edit Project dialog or the timestamp section of the dialog was missing.

  • Renamed the modules.js file to edit_project.js and move it into the project folder since it contained all of the code for the Edit Project dialog box.
  • Refactor this new edit_project file to encapsulate the UI functionality within a single editProjectDialog object.
  • Improve project loading code to detect the variety of timestamps found in existing projects. Missing or invalid Modified dates are replaced with a default date set to the current date/time. Missing or invalid Created dates are replaced with the value of the Modified date.
  • Standardized the 'created' field in the Project object to always be a Date object. This is addressed in issue Persist date elements of a project as epoch date #644.
  • Refactor jQuery references to standard DOM references.

pjewald and others added 27 commits July 14, 2021 14:09
Import form validator package.
Add crowbar to ensure event handlers are only loaded once.
@zfi zfi merged commit e2e2964 into develop Jul 16, 2021
@zfi zfi deleted the project_cleanup_01 branch July 16, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants