feat: show type check result while typing arguments #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the transformation function for the current argument will be executed on the current text for the argument. If an error occurs during transformation, it will be displayed in the argument suggestion. There is also now an `expensive` flag for types, indicating if this functionality should be disabled for the type.
paradoxuum
changed the title
App slice has been split into multiple slices and there is now a suggestion slice which is used instead of the suggestion context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements type checking while typing an argument. This is done by running the
transformfunction each time the text changes. If an error occurs, the message will be displayed in the argument suggestion.Since running transformation functions is potentially expensive, there is now an
expensiveflag for types, which can be set using the last parameter of theTypeBuilder.transformmethod. By default, this flag is set tofalse.Closes #2