refactor adapter/db/order includeBodyQuantityProductInProductDb function #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdaciuk
approved these changes
Aug 3, 2021
fdaciuk
requested changes
Aug 9, 2022
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [14.x] |
There was a problem hiding this comment.
Aqui já podemos usar a v16, que é LTS atual :)
Ou até a v18, se o GitHub Actions suportar (tem que ver se suporta)
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Se não me engano, essa lib já está na v3, dá pra atualizar tbem :D
| /* eslint-disable no-unused-vars */ | ||
| namespace NodeJS { | ||
| interface ProcessEnv { | ||
| MONGO_URL: string |
There was a problem hiding this comment.
Essa interface pode ficar aqui por enquanto, mas depois vamos fazer uma validação decente nas env vars pra ficar mais seguro xD
| import { | ||
| createCashback as createCashbackCore, | ||
| CreateCashback, | ||
| } from '../use-cases/create-cashback' |
There was a problem hiding this comment.
Aqui seria bom importar usando @
| import { | ||
| CreateOrder, | ||
| createOrder as createOrderCore, | ||
| } from '../use-cases/create-order' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR @fdaciuk