Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update pre-commit hooks #511

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Jul 8, 2024

Description

This PR updates the pre-commit hooks. It also fixes the currently broken lint job status by applying the pre-commit hooks on the code base.
Lastly I added a few rules to the ignore list and added a note. ruff usually does not fix logging messages to use f-strings, but with this code base, it does not understand that self.logger in an inherited class is actually a logger. I can't think of a way to fix this right now, so I added those rules to ignore list.

Types of changes

  • Code style update (formatting, renaming)
  • Build related changes

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • All new and existing tests passed.

Copy link

github-actions bot commented Jul 8, 2024

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 58% 35%
config 100% 100%
controllers 85% 56%
evaluators 64% 38%
harvester 60% 51%
helper 65% 55%
models 80% 87%
Summary 70% (6836 / 9789) 60% (2874 / 4790)

Copy link

github-actions bot commented Jul 8, 2024

📋 Pytest Results

19 tests  ±0   19 ✅ ±0   32s ⏱️ +7s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cbd5888. ± Comparison against base commit 9f419b8.

@huberrob huberrob merged commit 87adea3 into pangaea-data-publisher:master Jul 23, 2024
4 checks passed
@afuetterer afuetterer deleted the pre-commit-update branch July 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants