Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename application factory #435

Merged

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Oct 12, 2023

Description

This PR fixes a bug that was introduced in #421.

  • rename application factory to follow flask conventions (create_fuji_app -> create_app)
  • remove obsolete .parent resulting in wrong path in create_app

Related issue: #390

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afuetterer afuetterer marked this pull request as draft October 12, 2023 09:31
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

📋 Pytest Results

19 tests  +19   18 ✔️ +18   27s ⏱️ +27s
  1 suites +  1     0 💤 ±  0 
  1 files   +  1     1 +  1 

For more details on these failures, see this check.

Results for commit 086002c. ± Comparison against base commit 8a306e5.

♻️ This comment has been updated with latest results.

@afuetterer afuetterer force-pushed the 429-application-factory branch from 9db1259 to 086002c Compare October 12, 2023 09:39
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
. 50% 35%
config 100% 100%
controllers 86% 58%
evaluators 66% 39%
harvester 65% 55%
helper 62% 52%
models 81% 87%
Summary 70% (6541 / 9326) 60% (2741 / 4541)

@afuetterer afuetterer marked this pull request as ready for review October 12, 2023 09:43
@huberrob huberrob merged commit ef2147f into pangaea-data-publisher:master Oct 13, 2023
2 of 4 checks passed
@afuetterer afuetterer deleted the 429-application-factory branch October 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants