Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert json files to yaml #427

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Sep 30, 2023

Description

What do you think about storing the data in yaml files as well? For example the repodois.yaml is much more readable in yaml format. Also you can see differences in git more easily when single lines are added, changed.

Related issue: #392

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afuetterer afuetterer marked this pull request as draft September 30, 2023 08:12
@afuetterer afuetterer marked this pull request as ready for review October 1, 2023 17:28
@huberrob huberrob merged commit f659cf9 into pangaea-data-publisher:master Oct 11, 2023
1 of 3 checks passed
@afuetterer afuetterer deleted the json-to-yaml branch October 11, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants