Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: Use tm.external_error_raised for test_from_arrow_respecting_given_dtype_unsafe #60544

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mroeschke
Copy link
Member

Appears that pyarrow changed the exception message that we were matching against, so we should be using external_error_raised instead

e.g. https://github.com/pandas-dev/pandas/actions/runs/12281514975/job/34270563333?pr=60541

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Dec 11, 2024
@mroeschke mroeschke added this to the 2.3 milestone Dec 11, 2024
@mroeschke
Copy link
Member Author

Looks like test_from_arrow_respecting_given_dtype_unsafe is passing now on pyarrow-nightly so merging

@mroeschke mroeschke merged commit 38224dd into pandas-dev:main Dec 11, 2024
51 of 55 checks passed
@mroeschke mroeschke deleted the fix/pyarrow_nightly branch December 11, 2024 21:20
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 11, 2024
…r test_from_arrow_respecting_given_dtype_unsafe
mroeschke added a commit that referenced this pull request Dec 11, 2024
…sed for test_from_arrow_respecting_given_dtype_unsafe) (#60545)

Backport PR #60544: CI/TST: Use tm.external_error_raised for test_from_arrow_respecting_given_dtype_unsafe

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant