Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix docstrings errors SEM and GET_GROUP #60475

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

Axeldnahcram
Copy link
Contributor

@Axeldnahcram Axeldnahcram changed the title Fix docstrings errors SEM and GET_GROUP DOC: Fix docstrings errors SEM and GET_GROUP Dec 2, 2024
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Dec 3, 2024
@rhshadrach
Copy link
Member

@Axeldnahcram - can you merge main and resolve the conflicts.

@Axeldnahcram
Copy link
Contributor Author

@rhshadrach done. I also have a small question. I have had some issues running the formatting/cleaning steps of precommit/linting and I was wondering if we should not include it in the Making a pull request contribution guideline
Maybe it is intended ? Or maybe I simply missed a readme/documentation somewhere. Let me know what you think

@mroeschke mroeschke merged commit a36c44e into pandas-dev:main Dec 4, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @Axeldnahcram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants