BUG (string dtype): fix handling of string dtype in interchange protocol #60333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Nov 16, 2024
| @@ -410,7 +407,6 @@ def test_empty_string_column(): | |||
| tm.assert_frame_equal(df, result) | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)") | |||
| def test_large_string(): | |||
| # GH#56702 | |||
| pytest.importorskip("pyarrow") | |||
There was a problem hiding this comment.
Just below here (can't comment on the line), we still hardcode to object dtype, that should be
expected = pd.DataFrame({"a": ["x"]}, dtype="str")
|
Thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Nov 17, 2024
…ing dtype in interchange protocol
jorisvandenbossche
pushed a commit
that referenced
this pull request
Nov 17, 2024
…of string dtype in interchange protocol) (#60347) Backport PR #60333: BUG (string dtype): fix handling of string dtype in interchange protocol Co-authored-by: William Ayd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.