Merge pull request #55 from palantir/release/2.0.0

Release 2.0.0
palantir · Feb 13, 2017 · 427ff4b · 427ff4b · blueprint-bot · Feb 13, 2017
2 parents 9154683 + 7cf25ad
commit 427ff4b
Show file tree

Hide file tree

Showing 3 changed files with 562 additions and 121 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "svg-typewriter",
-  "version": "1.1.0",
+  "version": "2.0.0",
   "description": "SVG Text Measurement Line Wrapper",
   "main": "build/src/index.js",
   "types": "build/src/index.d.ts",

diff --git a/test/domTests.ts b/test/domTests.ts
@@ -46,13 +46,21 @@ describe("Utils.DOM Test Suite", () => {
     noneSVG.remove();
   });
 
-  it("transform works properly", () => {
+  it("transform before setting returns null", () => {
     const svg = generateSVG();
-    const translate = "translate(0, 0)";
     const rect = svg.append("rect");
     assert.equal(DOM.transform(rect), null);
+    svg.remove();
+  });
+
+  // This test is disabled because translations are stringified inconsistently
+  // across browsers. For example, some will drop the comma, and others will
+  // convert "translate(0, 0)" to "translate(0)"
+  xit("setting transform works properly", () => {
+    const svg = generateSVG();
+    const rect = svg.append("rect");
     DOM.transform(rect, 0, 0);
-    assert.equal(DOM.transform(rect), translate);
+    assert.equal(DOM.transform(rect), "translate(0, 0)");
     svg.remove();
   });
 });