-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define marker attributes on a external assembly #151
Conversation
The package content was changed to:
|
Thank you for your contribution! One of the benefits of Jab, as I see it, is not needing any external dependencies. There are reasons to have attributes as a separate assembly (like supporting InternalsVisibleTo), but it should be an opt-in rather than the default. I was thinking about having |
Done, the Jab no longer depends on Jab.Attributes. The package content was changed to:
|
All, done as suggested. Not sure about the naming of the compiler constants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
The issue or feature being addressed
Details on the issue fix or feature implementation