Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete existing tests #6

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Complete existing tests #6

merged 7 commits into from
Oct 13, 2023

Conversation

pahnev
Copy link
Owner

@pahnev pahnev commented Oct 12, 2023

No description provided.

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2023

Code Climate has analyzed commit e99484b and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fb24e4e) 84.94% compared to head (e99484b) 93.30%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   84.94%   93.30%   +8.36%     
==========================================
  Files          37       38       +1     
  Lines        1773     2956    +1183     
==========================================
+ Hits         1506     2758    +1252     
+ Misses        267      198      -69     
Files Coverage Δ
Sources/TMDBKit/Model/AccountState.swift 100.00% <ø> (ø)
...ces/TMDBKit/Networking/APIClient/TMDB+Search.swift 0.00% <ø> (ø)
Sources/TMDBKit/Networking/Endpoints/Lists.swift 100.00% <ø> (+100.00%) ⬆️
Tests/TMDBKitTests/AccountEndpointTests.swift 100.00% <100.00%> (ø)
...sts/TMDBKitTests/AuthenticationEndpointTests.swift 96.55% <100.00%> (+1.95%) ⬆️
Tests/TMDBKitTests/Helpers/MockAuth.swift 100.00% <ø> (ø)
Tests/TMDBKitTests/MovieEndpointTests.swift 100.00% <100.00%> (ø)
Tests/TMDBKitTests/PeopleEnpointTests.swift 99.05% <100.00%> (+1.95%) ⬆️
Tests/TMDBKitTests/TVEndpointTests.swift 100.00% <100.00%> (ø)
Tests/TMDBKitTests/TrendingEndpointTests.swift 100.00% <100.00%> (ø)
... and 2 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pahnev pahnev merged commit 66fa074 into main Oct 13, 2023
4 checks passed
@pahnev pahnev deleted the complete-existing-tests branch October 13, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant