Project Config #45
Open
Project Config #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
| $self = new static($index, $rootFolder); | ||
| $self->config = $config; | ||
| return $self; |
There was a problem hiding this comment.
Why not have just one constructor, with the following signature : public function __construct(Index $index, $rootFolder = "", Config $config = null). If $config is null, it can be initialized to Config::default(), right?
There was a problem hiding this comment.
it looks more elegant with named factories
There was a problem hiding this comment.
I'm not familiar with them (apart from the very ancient time where I learnt C++ and there were several possible constructors), but I guess it's something that might indeed come in handy if you don't want to remember the order of the 1878739 constructor arguments…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the #20