Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pagination from inifinite loading to paged pagination #500

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Change pagination from inifinite loading to paged pagination #500

wants to merge 10 commits into from

Conversation

Venefilyn
Copy link
Collaborator

@Venefilyn Venefilyn commented Dec 4, 2024 •
edited
Loading

This now has a context that each component under the provider can use.
With this we reduce the code we need to write to handle state handling
between components.

Infinite pagination has been replaced with per-page pagination which
should suit people better than infinitely loading.

Before
image

After
image

TODO:

  • Decide if we want this pagination
  • Migrate other components
  • Remove the end of pagination handling due to bug (insert issue link here)

RELEASE NOTES BEGIN
Change pagination from infinite loading to paged pagination.
RELEASE NOTES END

@Venefilyn Venefilyn marked this pull request as draft December 4, 2024 17:17
@usercont-release-bot
Copy link

usercont-release-bot commented Dec 4, 2024 •
edited
Loading

Preview: https://packit-dashboard-pr-500.surge.sh (deployed at Thu 30 Jan 2025, 13:25 UTC)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6cb8bf64e8ad4997b4bbefeb41eb0cfd

✔️ pre-commit SUCCESS in 2m 19s

@lbarcziova
Copy link
Member

packit/packit-service#2505 might affect this.

@lbarcziova
Copy link
Member

Once packit/packit-service#2645 is implemented, this should be changed adjusting to that, right?

@Venefilyn Venefilyn force-pushed the feat/proper-pagination branch from 870a935 to 731cf28 Compare January 30, 2025 12:32
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a6d04a800ccf4794a11620baefd5405a

✔️ pre-commit SUCCESS in 2m 06s

@Venefilyn Venefilyn force-pushed the feat/proper-pagination branch from 731cf28 to 6e17154 Compare January 30, 2025 12:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c4ed5a1fdd86448b8d2ef3df376ed0e8

✔️ pre-commit SUCCESS in 2m 03s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a4f2928fba4e4e1b9529c30a1f600d6b

✔️ pre-commit SUCCESS in 2m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/117ee4d3289846e8850ca9e8b3eb01a7

✔️ pre-commit SUCCESS in 2m 07s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5d2e9013093341388fc9aa6b10af9abc

✔️ pre-commit SUCCESS in 2m 05s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fddc1f788f4348cfa3fec904d5115baa

✔️ pre-commit SUCCESS in 2m 06s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/528a0efac752481a83b0f7d7d1a5ed7f

✔️ pre-commit SUCCESS in 2m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d4ce78506abb45409742d4b03662f582

✔️ pre-commit SUCCESS in 2m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b0f1d752c3bf457493298c8862cde2d4

✔️ pre-commit SUCCESS in 2m 09s

@Venefilyn
feat(Projects): Paginate with pages and context
67d4bf3 
This now has a context that each component under the provider can use.
With this we reduce the code we need to write to handle state handling
between components.

Infinite pagination has been replaced with per-page pagination which
should suit people better than infinitely loading.

feat: proper pagination
@Venefilyn
Copr: Migrate to page-based pagination
cddcb12
@Venefilyn
Koji: Migrate to page-based pagination
fffdefd
@Venefilyn
SRPM: Migrate to page-based pagination
4899a05
@Venefilyn
Testing Farm: Migrate to page-based pagination
6aeca55
@Venefilyn
Sync Release: Migrate to page-based pagination
854dc83
@Venefilyn
Bodhi: Migrate to page-based pagination
40bbcc5
@Venefilyn
OpenScanHub: Migrate to page-based pagination
c59a653
@Venefilyn
KojiTag: Migrate to page-based pagination
96cb5b5
@Venefilyn
Pipelines: Migrate to page-based pagination
ff21bc1
@Venefilyn Venefilyn force-pushed the feat/proper-pagination branch from b56bd55 to ff21bc1 Compare January 30, 2025 13:24
@Venefilyn Venefilyn marked this pull request as ready for review January 30, 2025 13:25
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2ff7f99d101a461f9aca485e931ea049

✔️ pre-commit SUCCESS in 2m 04s

@Venefilyn
Copy link
Collaborator Author

Once packit/packit-service#2645 is implemented, this should be changed adjusting to that, right?

@lbarcziova Might've missed this if I didn't answer in a meeting. But pagination in general would change so this PR doesn't introduce much extra code that would need to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Venefilyn @usercont-release-bot @lbarcziova