refactor: Use type converters instead calling moshi.adapter by hand #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few places in the code where calling `moshi.adapter` to marshall to/from strings in the database where type converters either already exist, or are straightforward to create. Create the missing type converters, and use them throughout. This simplifies several places where a Moshi instance no longer needs to be passed through several layers of method calls. Since this doesn't change the underlying database representation of the data there's no need to bump the database version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places in the code were calling
moshi.adapterto marshall to/from strings in the database where type converters either already exist, or are straightforward to create.Create the missing type converters, and use them throughout. This simplifies several places where a Moshi instance no longer needs to be passed through several layers of method calls.
Since this doesn't change the underlying database representation of the data there's no need to bump the database version number.