fix: Prevent crash on "hidden domains" page (#703)

The crash was caused by an uncaught exception when calling `MastodonApi#domainBlocks`. Update the `BackgroundMessageView` for the error message so it fills the screen like on other pages. Fixes #696
pachli · May 30, 2024 · 5610cd2 · 5610cd2
1 parent ab08974
commit 5610cd2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/app/src/main/java/app/pachli/components/instancemute/fragment/InstanceListFragment.kt b/app/src/main/java/app/pachli/components/instancemute/fragment/InstanceListFragment.kt
@@ -100,13 +100,16 @@ class InstanceListFragment :
         }
 
         viewLifecycleOwner.lifecycleScope.launch {
-            val response = api.domainBlocks(id, bottomId)
-            val instances = response.body()
-
-            if (response.isSuccessful && instances != null) {
-                onFetchInstancesSuccess(instances, response.headers()["Link"])
-            } else {
-                onFetchInstancesFailure(Exception(response.message()))
+            try {
+                val response = api.domainBlocks(id, bottomId)
+                val instances = response.body()
+                if (response.isSuccessful && instances != null) {
+                    onFetchInstancesSuccess(instances, response.headers()["Link"])
+                } else {
+                    onFetchInstancesFailure(Exception(response.message()))
+                }
+            } catch (e: Exception) {
+                onFetchInstancesFailure(e)
             }
         }
     }

diff --git a/app/src/main/res/layout/fragment_instance_list.xml b/app/src/main/res/layout/fragment_instance_list.xml
@@ -18,9 +18,8 @@
 
     <app.pachli.core.ui.BackgroundMessageView
         android:id="@+id/messageView"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_gravity="center"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
         android:visibility="gone"
         tools:visibility="visible" />
 </FrameLayout>