Pass createSession to native getSession call
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass createSession variable * Use Optional.of * Use final everywhere for params * Make getNativeSession return Optional
|
LGTM |
|
The v6.0.1 release is in progress... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on
pac4j-dev, this PR updates theServletSessionStoreto pass acreateSessionparameter to the "native"getSessionfunction. This mimics the implementation of other session stores, and should also prevent anIllegalStateExceptionfrom being thrown (originally addressed in c0b55af).In addition to passing
createSession, I alsogetHttpSessiontogetNativeSessionto align naming with theJEESessionStoreOptionalsyntax (map,filter, ...) instead of conditionalshttpSessionand its constructor, becausebuildFromTrackableSessioncreates a store with that session inline alreadyIf those changes seem too much, I can undo those of course.
Once this PR is in, I'll create a backport PR targeting the
5.0.xbranch.